Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is not failing on TypeScript errors #128

Open
Turbo87 opened this issue Jan 7, 2017 · 3 comments
Open

Build is not failing on TypeScript errors #128

Turbo87 opened this issue Jan 7, 2017 · 3 comments

Comments

@Turbo87
Copy link

Turbo87 commented Jan 7, 2017

I would assume that running ember build would fail when I create a type error like changing the return type of normalizePath() to boolean instead of string.

I'm seeing the following output:

/route-recognizer.ts(633,7): Type 'boolean' is not assignable to type 'string'.
/route-recognizer/normalizer.ts(6,10): Type 'string' is not assignable to type 'boolean'.

but the build still succeeds with exit code 0.

/cc @stefanpenner @rwjblue @nathanhammond @krisselden

@Turbo87
Copy link
Author

Turbo87 commented Jan 26, 2017

@stefanpenner @rwjblue @nathanhammond @krisselden any comments on this?

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 26, 2017

Yep. Fix it.

@chriskrycho
Copy link

Does adding noEmitOnError fix the problem? Seems to overlap in a weird way with noEmit, but that's the only thing I can think of which might help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants