Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce heartbeat message #313

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

reduce heartbeat message #313

wants to merge 3 commits into from

Conversation

NingLin-P
Copy link
Member

@NingLin-P NingLin-P commented Oct 31, 2019 •
edited

Signed-off-by: linning linningde25@gmail.com
When there is no pending Readindex, MsgAppend will do the work of MsgHeartbeat, so when we had broadcasted MsgAppend, we can reset heartbeat_elapsed to reduce MsgHeartbeat.

close #309

@NingLin-P
reduce heartbeat mssage
2991f78 
Signed-off-by: linning <linningde25@gmail.com>
@siddontang
Copy link
Contributor

maybe we can contribute it to etcd?

/cc @xiang90 @tbg

@siddontang
Copy link
Contributor

@NingLin-P have we done any benchmark?

@NingLin-P
Copy link
Member Author

@NingLin-P have we done any benchmark?

Not yet.

@Hoverbear Hoverbear changed the title reduce heartbeat mssage reduce heartbeat message Nov 7, 2019
@Hoverbear Hoverbear added the Feature Related to a major feature. label Nov 7, 2019
@NingLin-P
check whether bcast msg
de0cb5d 
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P NingLin-P mentioned this pull request Nov 12, 2019
Closed
@hzh0425
Copy link

hzh0425 commented Jun 15, 2021

Hello, excuse me. I would like to ask if there is benchmark in this PR?

@NingLin-P
Copy link
Member Author

Hello, excuse me. I would like to ask if there is benchmark in this PR?

I think there is no, this PR has been paused for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay Awaiting requested review from BusyJay

@overvenus overvenus Awaiting requested review from overvenus

At least 1 approving review is required to merge this pull request.

Assignees

@NingLin-P NingLin-P

Labels
Feature Related to a major feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce heartbeat message
4 participants
@NingLin-P @siddontang @hzh0425 @Hoverbear