Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move benches into harness #287

Open
Fullstop000 opened this issue Sep 10, 2019 · 3 comments
Open

Move benches into harness #287

Fullstop000 opened this issue Sep 10, 2019 · 3 comments

Comments

@Fullstop000
Copy link
Member

It seems that benches are unable to use harness based on the current project structure. How about moving the entire benches into harness? @nrc @Hoverbear

Now:

benches
harness
src

After:

harness
  benches
  src
  tests
src
@Hoverbear
Copy link
Contributor

I think this is reasonable!

@hicqu
Copy link
Contributor

hicqu commented Nov 7, 2019

I find some benchmarks about ProgressSets use some internal APIs. Is it better to move those benchmarks to source code file? I guess it's helpful to clean our APIs.

@Hoverbear
Copy link
Contributor

Maybe a src/progress/benches.rs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hoverbear @hicqu @Fullstop000