Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust utils-io test for lifecycle 1.0.3+ #434

Closed
wants to merge 1 commit into from

Conversation

spotrh
Copy link

@spotrh spotrh commented Feb 20, 2023

With lifecycle 1.0.3, the behavior of deprecate_warn() changed slightly. Specifically, when details is set, but not via a named vector, it now uses an info bullet by default. See: r-lib/lifecycle@54ef541

This change adjusts the utils-io.md expected strings to reflect the new result (and makes lifecycle >= 1.0.3 a requirement).

(the other way to fix this would be to use set_names() in utils-io.R, but that seemed more intrusive.)

With this change, the tests pass again with lifecycle 1.0.3+.

@jennybc
Copy link
Member

jennybc commented Feb 20, 2023

Thanks for bringing this up.

I think I will probably used named bullets going forward.
Or I might even be able to remove these deprecate_warn() calls, depending on what type of release I do. I.e. if it's a major release, I can rip out a lot of this backwards compatibility code.

So I'm not merging right away.

@hadley
Copy link
Member

hadley commented Nov 22, 2023

Looks like this snapshot got updated in the meantime, so this PR is no longer needed. Even though it didn't get merged we really appreciate you pitching in @spotrh!

@hadley hadley closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants