Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative names for gradient scales #5821

Open
teunbrand opened this issue Apr 2, 2024 · 0 comments · May be fixed by #5828
Open

More informative names for gradient scales #5821

teunbrand opened this issue Apr 2, 2024 · 0 comments · May be fixed by #5828

Comments

@teunbrand
Copy link
Collaborator

This issue separates out a discussion about (re)naming gradient scales from #3738.

To briefly recap, having sequential or diverging continuous scales is conceptually an important difference. The current naming of gradient scales does no favours distinguishing these types of scales. It was proposed herein that scale_{fill/colour}_gradient2() be renamed to scale_{fill/colour}_gradient_div().

I'd like to add to this proposal that scale_{fill/colour}_gradient() itself be renamed to scale_{fill/colour}_gradient_seq() to set these apart. scale_{fill/colour}_gradientn() can be used for either purpose, so I'll suggest that we leave that name as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant