Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setequal() with grouped data frame produces error in dplyr 0.7.6 #3704

Closed
Eli-Berkow opened this issue Jul 4, 2018 · 4 comments
Closed

setequal() with grouped data frame produces error in dplyr 0.7.6 #3704

Eli-Berkow opened this issue Jul 4, 2018 · 4 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@Eli-Berkow
Copy link

Eli-Berkow commented Jul 4, 2018

Using setequal() with a grouped data frame produces an error using dplyr 0.7.6

library(dplyr)
x <- iris %>% group_by(Species)
setequal(iris, iris)
setequal(iris, x)
setequal(x, iris)
setequal(x, x)

Output:

> setequal(iris, iris)
TRUE
> setequal(iris, x)
TRUE
> setequal(x, iris)
Error in grouped_df_impl(out, group_vars(x), group_drop(x), FALSE) : 
  Could not convert using R function: as.data.frame.
> setequal(x, x)
Error in grouped_df_impl(out, group_vars(x), group_drop(x), FALSE) : 
  Could not convert using R function: as.data.frame.

Using the development version dplyr 0.7.99.9000 I get the following:

> setequal(x, iris)
Error in grouped_df_impl(out, group_vars(x), group_drop(x), FALSE) : 
  unused arguments (group_drop(x), FALSE)
> setequal(x, x)
Error in grouped_df_impl(out, group_vars(x), group_drop(x), FALSE) : 
  unused arguments (group_drop(x), FALSE)
@krlmlr
Copy link
Member

krlmlr commented Jul 15, 2018

Thanks, confirmed. Fixed in master, we might want to release 0.7.7. Please ungroup arguments to setequal() for now.

@krlmlr krlmlr added the bug an unexpected problem or unintended behavior label Jul 15, 2018
@romainfrancois
Copy link
Member

Closing as this is fixed in master.

@krlmlr
Copy link
Member

krlmlr commented Sep 15, 2018

Added this to the new r-0.7.8 branch, should we ever want to submit another minor update.

@lock
Copy link

lock bot commented Mar 14, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants