From 4d793e48591f3d99844d5325811f72f006eb9151 Mon Sep 17 00:00:00 2001 From: Michael Gangolf Date: Fri, 1 Mar 2024 10:12:27 +0100 Subject: [PATCH 1/2] chore(android): try/catch around unlink snapshots --- android/titanium/libv8-services.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/android/titanium/libv8-services.js b/android/titanium/libv8-services.js index b30a6d7c6ca..aceb36f65a6 100644 --- a/android/titanium/libv8-services.js +++ b/android/titanium/libv8-services.js @@ -125,7 +125,11 @@ async function generateSnapshot(v8SnapshotHeaderFilePath, rollupFileContent) { } // Delete snapshot blob. - await fs.unlink(blobPath); + try { + await fs.unlink(blobPath); + } catch (e) { + // Do nothing... + } } // Generate 'V8Snapshots.h' from template From f538611d9ff5bc9146bbe9845a41378c8006e8b4 Mon Sep 17 00:00:00 2001 From: Michael Gangolf Date: Tue, 16 Apr 2024 17:30:57 +0200 Subject: [PATCH 2/2] use remove --- android/titanium/libv8-services.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/android/titanium/libv8-services.js b/android/titanium/libv8-services.js index aceb36f65a6..d3e8100e0fe 100644 --- a/android/titanium/libv8-services.js +++ b/android/titanium/libv8-services.js @@ -125,11 +125,7 @@ async function generateSnapshot(v8SnapshotHeaderFilePath, rollupFileContent) { } // Delete snapshot blob. - try { - await fs.unlink(blobPath); - } catch (e) { - // Do nothing... - } + await fs.remove(blobPath); } // Generate 'V8Snapshots.h' from template