Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add logs export to local storage #1664

Closed
Fede2782 opened this issue Apr 25, 2024 · 9 comments
Closed

[Feature] Add logs export to local storage #1664

Fede2782 opened this issue Apr 25, 2024 · 9 comments

Comments

@Fede2782
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I'm always frustrated when I need to get KernelSU logs because when I click the Logs button in Settings it opens the Share menu, this means that if I have to get the logs file on the device it has been captured on, I need to share it to another device first or upload to some cloud service.

Describe the solution you'd like.

It should open a popup which asks if the user wants to share or save on device. In case the user wants to save on device a DocumentsUI screen or similar should allow the user to save the logs where he desires on by default in some Download folders

Describe alternatives you've considered.

Instead of sharing it and then deleting it at least give the user the path where the log is saved

Additional context

No response

@LHC12580

This comment was marked as off-topic.

@tiann

This comment was marked as off-topic.

@LHC12580
Copy link

LHC12580 commented May 7, 2024 via email

@klxiaoniu
Copy link

How to design this interaction? Simply replacing sending logs with save logs, like LSPosed, or add a dialog that allows to choose save or share?

@tiann
Copy link
Owner

tiann commented May 9, 2024 via email

@tiann
Copy link
Owner

tiann commented May 9, 2024

Or we can add an Intent to ourselves, and when we share to this intent, it will be saved locally.

@Fede2782
Copy link
Contributor Author

Or we can add an Intent to ourselves, and when we share to this intent, it will be saved locally.

I think the best way could be to click on Capture logs -> Let the user chose if he wants to save locally or wants to share. In the first case a DocumentsUI page could be opened to let user save where he wants. In the second case the share menu could open

tiann added a commit that referenced this issue May 23, 2024
- Added export logs to local storage
[1664](#1664)

---------

Co-authored-by: weishu <twsxtd@gmail.com>
@tiann
Copy link
Owner

tiann commented May 23, 2024

#1741

@tiann tiann closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants