Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add the x86_64 LKM's as well to your releases. #1533

Open
newbit1 opened this issue Mar 25, 2024 · 7 comments
Open

Please add the x86_64 LKM's as well to your releases. #1533

newbit1 opened this issue Mar 25, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@newbit1
Copy link

newbit1 commented Mar 25, 2024

Dear @tiann ,

i managed to add the ksuinit and the LKM to the AVDs ramdisk.

But the Kernel log conplaines about the wrong architectur of the module and can't load it.

It seems the provided LKM's on the release page are exclusiv arm or rather aarch64.

So could you please add the x86_64 LKM's to your release page as well?

Also, can you tell when you will release the AVD kernels? I tried the ones from the action workflows and they boot up right away.

Thanks
NewBit

@tiann tiann added the enhancement New feature or request label Mar 26, 2024
@tiann
Copy link
Owner

tiann commented Mar 26, 2024

avd kernel is not GKI, you must compile exactly the same version with the AVD, so we won't release avd kernels.

as for LKM, we may do it, you can copy the workflows and try first.

@newbit1
Copy link
Author

newbit1 commented Mar 26, 2024

avd kernel is not GKI, you must compile exactly the same version with the AVD, so we won't release avd kernels.

according to the AOSP, they should be GKI since Android 12 and Kernel 5.10

as for LKM, we may do it, you can copy the workflows and try first.

Thx, in which workflows can I find the x86_64 LKM's? Are they uploaded to your Telegram Groups as well as the AVD kernels?

@tiann
Copy link
Owner

tiann commented Mar 26, 2024

AVD has many kernel modules, and they may not work on different kernel versions (even if the KMI is the same); no matter how Google documents it, that's just the way it is.

@tiann
Copy link
Owner

tiann commented Mar 26, 2024

build-lkm.yml is the workflow to build LKM

@newbit1
Copy link
Author

newbit1 commented Mar 26, 2024

build-lkm.yml is the workflow to build LKM

there are only the aarch64 LKM's in it,
but not the x86_64.

@tiann
Copy link
Owner

tiann commented Mar 27, 2024

we never build x86_64 before, you should modify it

@newbit1
Copy link
Author

newbit1 commented Mar 27, 2024

ah ok I see, yeah I can't and further more, won't do that. I would like to stay with the official state of ksu. So my rootavd script users can have the up-to-date versions of ksu. It just doesn't makes sense, to have a ksu version besides the official one.

That is why asked you to add these arch and AVD kernel as well to the release.

So both emulator types can work with ksu. Ideally with both modes, kernel replacement and LKM.

Well I must say, I presume you just have to switch to another target and it will build. I don't want you to rewrite your code, just to have it compatible with AVDs. This would be way to much effort.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants