Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch size matters in training #17

Open
WizardMx opened this issue Apr 17, 2024 · 0 comments
Open

batch size matters in training #17

WizardMx opened this issue Apr 17, 2024 · 0 comments

Comments

@WizardMx
Copy link

in adapt_llava.py, you have this

for j in range(8):
                        cur_image_features = image_features[cur_image_idx+j*4]

I don't quite understand this:
First, cur_image_idx keeps being 0, which means you don't support multi-image training case
Also, I think 4 there should be consistent with the batch size, not always 4.

Somebody has the same confusion with me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant