Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth says "Saved Successfully" when it fails #1537

Open
awstlaur opened this issue May 7, 2024 · 0 comments
Open

Oauth says "Saved Successfully" when it fails #1537

awstlaur opened this issue May 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@awstlaur
Copy link

awstlaur commented May 7, 2024

Describe the bug
Generating an Oauth token gives the popup "Saved Successfully" with green text despite failing.

To Reproduce
Under Auth -> Oauth2, send an oauth request with invalid credentials.
Screenshot 2024-05-07 at 7 49 56 AM

Observe the the success popup, but observe the following in the output:

OAuth2 Client Credentials Request: https://redacted.domain/oauth2/token
Request Method: POST
Request Headers:
{
  "Content-Type": "application/x-www-form-urlencoded"
}
Request Body:
grant_type=client_credentials&client_id=invalid_client_id&client_secret=invalid_client_secret

OAuth Response:
{
  "error_description": "Authorization failed. Invalid credentials",
  "error": "invalid_client"
}

Expected behavior
I expect a failure popup

Platform:

  • OS: macOS Sonoma 14.4.1
  • vscode version: 1.89.0
  • node version: 18.18.2
  • extension version: v2.22.1

Are you using the free version/paid version/trial:
Free

@awstlaur awstlaur added the bug Something isn't working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant