Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form inputs do not work well with IME enabled #1433

Open
tmokmss opened this issue Dec 4, 2023 · 1 comment
Open

Form inputs do not work well with IME enabled #1433

tmokmss opened this issue Dec 4, 2023 · 1 comment
Labels
bug Something isn't working Priority Implement this asap

Comments

@tmokmss
Copy link

tmokmss commented Dec 4, 2023

Describe the bug
When I try to type something with IME enabled into the form e.g. query parameters below, it does not work well because the input is fixed right after we type a key. This makes it a lot difficult to use CJK values as a form input.

image

I think we need to specially handle keydown events using event.isComposing property (ref).

eventTarget.addEventListener("keydown", (event) => {
  if (event.isComposing || event.keyCode === 229) {
    return;
  }
  // do something
});

To Reproduce
Enable Japanese keyboard, and type a -> i.

Current behavior: as soon as we type each key, each letter is forcefully converted to and

Expected behavior
Expected behavior: It should allow us to convert あい to other candidates like .

Platform:

  • OS: macOS
  • vscode version: 1.84.2
  • extension version: 2.16.2

Are you using the free version/paid version/trial: free version

@tmokmss tmokmss added the bug Something isn't working label Dec 4, 2023
@rangav
Copy link
Collaborator

rangav commented Dec 5, 2023

Thanks @tmokmss for reporting the bug, Will fix it asap.

@rangav rangav added the Priority Implement this asap label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority Implement this asap
Projects
None yet
Development

No branches or pull requests

2 participants