Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use autogenerated calendar for Japanese Holidays #468

Open
kazushi3 opened this issue Jul 13, 2023 · 2 comments
Open

Do not use autogenerated calendar for Japanese Holidays #468

kazushi3 opened this issue Jul 13, 2023 · 2 comments

Comments

@kazushi3
Copy link

I don't think autogenerated calendar works for Japanese. It contains too many events (not national holidays). For example, "バレンタイン", "七五三", and "七夕" are not holidays.

Which source are you using?

@Sancus
Copy link
Member

Sancus commented Jul 13, 2023

https://calendarific.com/api-documentation

We currently include national, local, and "observance" holidays. We could probably consider excluding the latter. It's kind of a judgement call on whether people want dates that are not explicitly work holidays. I mean, I know バレンタイン is not a holiday in Canada either so I wouldn't mind having it on the calendar, but I know it's not a work holiday.

@kazushi3 kazushi3 reopened this Jul 15, 2023
@kazushi3
Copy link
Author

I understand your idea.
I think we need description about "observance" holidays.

And I found another problem in new calendar. Substitute holiday is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants