Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default should be en-GB #359

Open
getsnoopy opened this issue Jan 10, 2023 · 1 comment
Open

Default should be en-GB #359

getsnoopy opened this issue Jan 10, 2023 · 1 comment

Comments

@getsnoopy
Copy link

It seems like the website has multiple issues regarding defaults and language detection:

Issue 1

Problem: If the browser's locale is not in the xx-YY format but is still BCP 47 compliant, it doesn't work properly. For example, my browser's locale is set to en-GB-oxendict, but the website chooses en-US anyway.

Solution: Resolve BCP 47 tags correctly and fall back to the most appropriate locale.

Issue 2

Problem: It seems like the website maps en to en-US, which is essentially the incorrect choice for 74% of the English-speaking world that is not the US, Liberia, or the Philippines.

Solution: It should be en-GB instead, which is what the overwhelming majority of the world uses.

Issue 3

Problem: On the home page, the language chooser in the footer has the label English and English (British), etc. for the other Englishes, giving the false sense—when the drop-down is closed—that there are no other English choices, and—when the drop-down is open—that US English is the "default English of the world", which is the opposite of the truth.

Solution: Either English should map to en-GB, or the label for US English should change to English (American) to be consistent and clear about what the user is getting.

@Sancus
Copy link
Member

Sancus commented Jan 11, 2023

  1. Yeah, we could probably improve this, https://pypi.org/project/python-bcp47/ would likely do a better job than the current code.
  2. The default is the base content language on this repository, content is written in en-US first and then translated to other languages. This is the same mapping mozilla.org uses. en is a fallback code, no app should ever use it as the primary. Chrome, Firefox, and Edge all specify region for English. So this isn't really an issue in practice.
  3. I agree, it should be English (United States). That can be easily changed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants