Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure black theme UI quirks #1353

Open
codenyte opened this issue May 4, 2024 · 4 comments
Open

Pure black theme UI quirks #1353

codenyte opened this issue May 4, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@codenyte
Copy link

codenyte commented May 4, 2024

Bug Description

There are multiple problem with the Pure black theme, but I'll report as one issue. Thankfully some will already get fixed in PR #1347.

There are multiple issues with the top app bar, I'm not sure if this is the expected behavior but it has a grey-ish color while the rest of the app background is black. One example of this is the settings page:

Either the search bar needs more padding at the top or the top app bar needs to have the grey background removed.

Another issue with the top app bar occurs on the Feed page when "Hide Top Bar on Scroll" is enabled:

This could also be fixed by just removing the grey background, or by keeping it and also applying it to the notification/status bar (as it is the case when "Hide Top Bar on Scroll" is disabled).

Some sections of the app like "Explore instance" or "Create Comment'"don't use the black theme at all, even if it is enabled:

Steps to Reproduce

  1. Select Pure black theme
  2. Go to the aforementioned areas of the app

Additional Context

No response

App Version

0.4.0-1

Device

Pixel 6a

OS

Android 14 (GrapheneOS)

@codenyte codenyte added the bug Something isn't working label May 4, 2024
@codenyte
Copy link
Author

codenyte commented May 4, 2024

Probably not that relevant, but the About -> Licenses screen doesn't use the pure black theme either:

@codenyte
Copy link
Author

codenyte commented May 4, 2024

The Account settings page also looks pretty weird

@CTalvio
Copy link
Collaborator

CTalvio commented May 5, 2024

Account settings will be fixed by my PR.

I'll eventually look at the rest as well, and any cases I find in my everyday use as well.

@codenyte
Copy link
Author

codenyte commented May 5, 2024

Oh I'm sorry I didn't realize that this was included in your PR

@CTalvio CTalvio self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants