Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thunder sets the refresh rate to 60hz #1342

Open
cyrneko opened this issue May 2, 2024 · 5 comments
Open

Thunder sets the refresh rate to 60hz #1342

cyrneko opened this issue May 2, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@cyrneko
Copy link

cyrneko commented May 2, 2024

Bug Description

When entering the app, my phone goes down to 60hz despite the fact I've set the minimum to 90hz. This is evident when looking at the refresh rate indicator from the developer options.

Expected Behaviour

The app shouldn't change my refresh rate.

Steps to Reproduce

  1. Set refresh rate to 90hz or above
  2. Open the app
  3. Observe the issue

Additional Context

No response

App Version

0.3.0 F-Droid

Device

Poco F3, EU

OS

Android 13, LineageOS 20, lineage_alioth-userdebug 13 TQ3A.230901.001 eng.root.20240310.120731 dev-keys

@cyrneko cyrneko added the bug Something isn't working label May 2, 2024
@hjiangsu
Copy link
Member

Hey, sorry for the late reply!

When entering the app, my phone goes down to 60hz despite the fact I've set the minimum to 90hz.

When this happens, does it only set it to 60Hz when you have Thunder open? Or does set it system wide even after you close Thunder? (i.e., system is originally at 90Hz, open Thunder which brings it down to 60Hz, close Thunder and system is still set to 60Hz)

If it only sets the refresh rate when you're in Thunder, then that might be an issue with the app determining the proper refresh rate to use. It might be a bit tricky to figure out the system's refresh rate, and force Thunder to use that.

@cyrneko
Copy link
Author

cyrneko commented May 15, 2024

Hey, sorry for the late reply!

When entering the app, my phone goes down to 60hz despite the fact I've set the minimum to 90hz.

When this happens, does it only set it to 60Hz when you have Thunder open? Or does set it system wide even after you close Thunder? (i.e., system is originally at 90Hz, open Thunder which brings it down to 60Hz, close Thunder and system is still set to 60Hz)

If it only sets the refresh rate when you're in Thunder, then that might be an issue with the app determining the proper refresh rate to use. It might be a bit tricky to figure out the system's refresh rate, and force Thunder to use that.

It has 60hz only when the app is open, it returns to 90/120hz when the app is closed.

@hjiangsu
Copy link
Member

Thanks for the confirmation - this might be a bit tricky to solve.

For some reference, Thunder uses an external package which determines the appropriate refresh rate based on the device's available resolutions/refresh rates. This might be the case where the package isn't able to properly determine the correct refresh rate and falls back to the default 60Hz.

Just for confirmation, @micahmo could you let me know if Thunder runs at a high-refresh rate when testing on a physical device? If so, then this issue might be an edge-case.

@cyrneko
Copy link
Author

cyrneko commented May 21, 2024

FWIW, I had to re-flash my device due to a little whoopsie on my end, ended up flashing Android 14 instead and it works there 🫠

Unless someone else can reproduce this, I guess this should be closed.

@micahmo
Copy link
Member

micahmo commented May 21, 2024

Just for confirmation, @micahmo could you let me know if Thunder runs at a high-refresh rate when testing on a physical device? If so, then this issue might be an edge-case.

I can say that the OS overlay reports 120, and I can also say FlutterDisplayMode.setHighRefreshRate(); attempts to use 120. However, to the eye, it doesn't feel as smooth as some other apps. But that may be more an issue on our side with rebuilds, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants