Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release breaks full height images in tablet mode #1330

Open
Fmstrat opened this issue Apr 28, 2024 · 1 comment
Open

Latest release breaks full height images in tablet mode #1330

Fmstrat opened this issue Apr 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Milestone

Comments

@Fmstrat
Copy link
Contributor

Fmstrat commented Apr 28, 2024

Bug Description

When full height images are on in tablet mode, black baras appear around vertically squashed images

Screenshot_20240427_221737_Thunder

Expected Behaviour

The vertically squashed image should take up the full height.

Steps to Reproduce

  • Tablet mode
  • Card view
  • Full height images

Additional Context

No response

App Version

0.3.0

Device

Samsung Tab S9

OS

Android 14

@Fmstrat Fmstrat added the bug Something isn't working label Apr 28, 2024
@hjiangsu
Copy link
Member

Found the issue, made a PR for it. It'll most likely land on 0.4.0-2 nightly! (already submitted 0.4.0-1 nightly for review before this fix so I won't be able to push it to that one)

@hjiangsu hjiangsu self-assigned this Apr 29, 2024
@hjiangsu hjiangsu added the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Apr 29, 2024
@hjiangsu hjiangsu added this to the 0.4.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version
Projects
None yet
Development

No branches or pull requests

2 participants