Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autoplay videos #1177

Open
Contruffin opened this issue Mar 8, 2024 · 6 comments
Open

Do not autoplay videos #1177

Contruffin opened this issue Mar 8, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request in-progress Indicates that an issue is currently being worked on

Comments

@Contruffin
Copy link

Is Your Feature Request Related to a Problem?

The current behavior of the app is that it autoplays embedded videos when the post is opened. This is unusual and unexpected behavior for several reasons:

  • The native Lemmy website does not autoplay embedded videos and requires users to click the play button in order to play the video
  • The app does not distinguish between embedded videos and regular links. The user does not know if a post is a link to a website or if it is a video until after the user taps on the post.

This is somewhat related to another issue posted recently (#1161), where a user requested auto-mute functionality. Both issues stem from the fact that it is a nuisance to have a video play unexpectedly.

Feature Description

When a video is loaded in the app, do not play the video until the user taps on the play button.

Alternative Solutions

It may also be helpful to have a separate icon to mark videos. Maybe a triangle play button? Currently, it is being marked with the link icon (chain symbol), which makes it impossible to distinguish between a regular link. However, I'm unsure if that's technically feasible

Additional Context

No response

@Contruffin Contruffin added the enhancement New feature or request label Mar 8, 2024
@hjiangsu
Copy link
Member

Thanks for the report! Could you elaborate a bit more about what you mean by "embedded videos"? Right now, Thunder doesn't support in-app video formats (this is still WIP).

Aside from videos, the only animated format that is supported at the moment are GIFs (perhaps you meant GIFs?).

It would be helpful if you could provide an example post of what you mean here so that I can reproduce the issue!

@Contruffin
Copy link
Author

Contruffin commented Mar 11, 2024 via email

@hjiangsu
Copy link
Member

Ahh interesting - it must be links that point straight to a video file that the in-app browser then displays as a regular video (e.g., links that end in .mp4)

I think once we add in native video playing functionality, we can make it so that videos are muted + do not autoplay. I'm not sure if we can currently control that with the linked "embedded" videos though.

@Contruffin
Copy link
Author

Did some quick browsing through some video communities and found an example of what I mean. Please see the link for an example:
https://lemm.ee/post/21763351

Based on the link, I believe you may be right. It's a shame that it's not really something that can be controlled for now, since getting one of these videos can be quite disruptive (especially in public!) Anyways, thanks for all your hard work!

@hjiangsu
Copy link
Member

Thanks for the link example! Something that we might be able to do in the meantime while the in-app video player is being worked on is to add an additional badge if we detect these types of links (by detecting the ending of the url to see if its a video type).

This might reduce the disruption at least for now!

@hjiangsu hjiangsu self-assigned this Mar 11, 2024
@hjiangsu hjiangsu added the in-progress Indicates that an issue is currently being worked on label Mar 11, 2024
This was referenced Mar 11, 2024
@hjiangsu
Copy link
Member

Update: There is now an open PR which adds in a badge for detecting video URLs. This only applies to URLs where the ending is a video type (.mp4, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress Indicates that an issue is currently being worked on
Projects
None yet
Development

No branches or pull requests

2 participants