Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories with special characters (umlauts, maybe more) are not converted #299

Open
devdan opened this issue Jun 10, 2022 · 3 comments
Open

Comments

@devdan
Copy link

devdan commented Jun 10, 2022

Whenever a directory has umlauts in the name, the web page will neither display thumbnails, nor any other size of the pictures.
This also affects all sub directories, even if their names do not contain any special characters.

However, all the different versions are present in the media directory, they are just not displayed for any reason.

@devdan
Copy link
Author

devdan commented Jun 10, 2022

Sorry, the title is misleading. They are converted, but they are not displayed.

@devdan
Copy link
Author

devdan commented Jun 10, 2022

On the ext4 partition where the gallery is created, everything seems to be fine. The issue appears when it is copied to a FAT partition.

For the html files the umlauts are converted to the letters without the dots, maybe you could do the same with the directory names to prevent such issues.

@rprieto
Copy link
Member

rprieto commented Dec 5, 2023

Sorry about the slow reply to this issue!
You raise a very good point about how Thumbsup sanitizes HTML file names but not media folders & names.

For now we could add something in the documentation about using a tool like detox on the input folder. Thumbsup should not require you to change your input files, but it can be a temporary workaround.

We should also look into having "url safe" names for all generated content. This would force a rebuild of any existing media that uses special characters, so it might have to be optional at first.

What do you think of a new optional parameter called --sanitize-paths true or --url-safe-paths true? If enabled it would slugify output paths, including folders and file names. One problem will be if 2 different files end up having the same “url safe” version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants