Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure custom ca chain, client cert and private key #803

Open
dxdxdt opened this issue Sep 9, 2022 · 2 comments
Open

Configure custom ca chain, client cert and private key #803

dxdxdt opened this issue Sep 9, 2022 · 2 comments
Labels
App Issue affects the standalone application enhancement
Milestone

Comments

@dxdxdt
Copy link
Contributor

dxdxdt commented Sep 9, 2022

(Cont'd from #799)

My use case requires that the client supports a custom ca chain, a client certificate and a private key as the server mandate mutual TLS verification. I've been happy with using the Thunderbird plugin, which gets all the connection info from the Mozilla framework. It seems that you guys will discontinue the plugin so if I should switch over to the standalone version, I'd need to be able to configure them.

python-managesieve have options for these, but I prefer using the GUI. Would you consider merging into master if I(or you) implemented these settings?

@thsmi
Copy link
Owner

thsmi commented Sep 10, 2022

Contributing it always well come. Just create a pull request and I'll be happy to review and merge it.

As far as I understood this you are willing to implement a SASL External implementation for the application?
Technically this should be not too difficult. The TLS Layer, where external lives, is provided by node. and the XMPP guys have it up and running: https://servicelab.org/2012/04/26/how-to-use-xmpp-sasl-external-with-node-js/ .

As this project is a one man show, it is unlikely that I'll find time for this soon. My priorities are basically keeping the App alive, then keeping the WebExtension alive and if time is left adding new features. So feel free to provide a patch.

By the way are no plans to deprecate the Thunderbird WebExtension, but my spare time is currently very limited and maintaining the Thunderbird WebExtension got painful and time consuming over the last years. Until now no major Electron release broke the Application, in contrast every Thunderbird in the last year broke the WebExtension. And the really annoying part all of these breaking changes landed always few weeks before the final release which gives an add-on developer no time for fixing and testing.

@thsmi thsmi added WebExtension Issue affects Thunderbird WebExtension enhancement labels Sep 10, 2022
@thsmi thsmi added this to the Future milestone Sep 10, 2022
@thsmi thsmi added App Issue affects the standalone application and removed WebExtension Issue affects Thunderbird WebExtension labels Feb 4, 2023
@dxdxdt
Copy link
Contributor Author

dxdxdt commented Oct 13, 2023

Screenshot from 2023-10-13 22-42-53

Screenshot from 2023-10-16 20-05-46

Something like this. Will make a pull request along with other improvements and bug fixes.

dxdxdt added a commit to dxdxdt/sieve that referenced this issue Oct 17, 2023
- Add facilities for using custom CA, client certificate and private key
- Use SNI if using custom client certificate and private key
- Fix broken `ignoreCertErrors()`
- Change behaviour of "Forget Password" button ...
  - The button becomes disabled after a click event rather than
    disappearing
  - The button clears both auth password and TLS private key passphrase
- Pressing 'Ctrl + Shift + I' or 'F12' combo launches dev tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Issue affects the standalone application enhancement
Projects
None yet
Development

No branches or pull requests

2 participants