Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchanges have no idea of precision #740

Open
ydm opened this issue Aug 6, 2021 · 0 comments
Open

Exchanges have no idea of precision #740

ydm opened this issue Aug 6, 2021 · 0 comments

Comments

@ydm
Copy link
Contributor

ydm commented Aug 6, 2021

On the client side (i.e. exchange.IBotExchange.SubmitOrder()) we fill float64s for price, amount, etc. Proper precision should be handled at exchange level as it is (1) exchange-dependent, (2) imprecise to round a float64 on the client side and expect the string representation to reflect that rounding precisely.

@ydm ydm changed the title Exchanges have no idea of asset precision Exchanges have no idea of precision Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant