New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitstamp: depreciated balances *_usd _ fee #1271
Comments
Beadko
added a commit
to Beadko/gocryptotrader
that referenced
this issue
Jul 30, 2023
15 tasks
Beadko
added a commit
to Beadko/gocryptotrader
that referenced
this issue
Jul 31, 2023
Beadko
added a commit
to Beadko/gocryptotrader
that referenced
this issue
Oct 11, 2023
thrasher-
pushed a commit
that referenced
this issue
Oct 13, 2023
…nd test coverage (#1289) * Bitstamp: WIP fixing trading fees * Bitstamp/amended the TestGetFee test and currected the getTradingFee function * Bitstamp: TestGetFee implemented for maker and taker * Bitfinex: added a wrapped error * Bitstamp: GetTradingFee and test updated, fetched from the API Progresses #1271 * Bitstamp: minor changes- whitespace removal and comment added * Bitstamp: fixed lint issues in TestGetBalance and TestGetTransactions * Bitstamp:Typo in types TradingFee comment * Bitstamp: GetAccountTradingFees at view the fees on all pairs modified: exchanges/bitstamp/bitstamp.go * Bitstamp: returning the TradingFee info instead of just MakerTakerFees * Bitstamp:TestGetAccountTradingFees + TestGetAccountTradingFees added,data structure amended to match the outcome * Bitstamp:error and a test for empty pair added in GetAccountTradingFee * Bitstamp: RM the whitespace linter error
shazbert
pushed a commit
to shazbert/gocryptotrader
that referenced
this issue
Oct 17, 2023
…nd test coverage (thrasher-corp#1289) * Bitstamp: WIP fixing trading fees * Bitstamp/amended the TestGetFee test and currected the getTradingFee function * Bitstamp: TestGetFee implemented for maker and taker * Bitfinex: added a wrapped error * Bitstamp: GetTradingFee and test updated, fetched from the API Progresses thrasher-corp#1271 * Bitstamp: minor changes- whitespace removal and comment added * Bitstamp: fixed lint issues in TestGetBalance and TestGetTransactions * Bitstamp:Typo in types TradingFee comment * Bitstamp: GetAccountTradingFees at view the fees on all pairs modified: exchanges/bitstamp/bitstamp.go * Bitstamp: returning the TradingFee info instead of just MakerTakerFees * Bitstamp:TestGetAccountTradingFees + TestGetAccountTradingFees added,data structure amended to match the outcome * Bitstamp:error and a test for empty pair added in GetAccountTradingFee * Bitstamp: RM the whitespace linter error
shazbert
pushed a commit
to shazbert/gocryptotrader
that referenced
this issue
Nov 10, 2023
…nd test coverage (thrasher-corp#1289) * Bitstamp: WIP fixing trading fees * Bitstamp/amended the TestGetFee test and currected the getTradingFee function * Bitstamp: TestGetFee implemented for maker and taker * Bitfinex: added a wrapped error * Bitstamp: GetTradingFee and test updated, fetched from the API Progresses thrasher-corp#1271 * Bitstamp: minor changes- whitespace removal and comment added * Bitstamp: fixed lint issues in TestGetBalance and TestGetTransactions * Bitstamp:Typo in types TradingFee comment * Bitstamp: GetAccountTradingFees at view the fees on all pairs modified: exchanges/bitstamp/bitstamp.go * Bitstamp: returning the TradingFee info instead of just MakerTakerFees * Bitstamp:TestGetAccountTradingFees + TestGetAccountTradingFees added,data structure amended to match the outcome * Bitstamp:error and a test for empty pair added in GetAccountTradingFee * Bitstamp: RM the whitespace linter error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bitstamp have deprecated balances _usd _ fee in favour of withdrawal fee.
The api still returns the fields but they're all 0.
Fix: we drop _ _fee internally.
The text was updated successfully, but these errors were encountered: