Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileignoreconfig in talisman are not considered in scan mode #451

Open
aravindbuilt opened this issue Feb 5, 2024 · 0 comments
Open

fileignoreconfig in talisman are not considered in scan mode #451

aravindbuilt opened this issue Feb 5, 2024 · 0 comments

Comments

@aravindbuilt
Copy link

aravindbuilt commented Feb 5, 2024

I've added fileignoreconfig in .talismanrc. The observations are as follows

  • when I ran talisman --scan, the fileignoreconfig are not considered and scans the whole commit history
  • When I ran talisman --ignoreHistory --scan, the fileignoreconfig are included and scans the head

Expectation

fileignoreconfig should be included for all type of scans

Code Reference

if mode == HookMode {

System Details

  • OS: Mac OS
  • Version 1.32.0
@aravindbuilt aravindbuilt changed the title Talismanrc is fileignoreconfig are not considered in scan mode fileignoreconfig in talisman are not considered in scan mode Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant