Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the name change from factory_girl to factory_bot? #1053

Closed
EverybodyKurts opened this issue Oct 20, 2017 · 4 comments
Closed

Why the name change from factory_girl to factory_bot? #1053

EverybodyKurts opened this issue Oct 20, 2017 · 4 comments

Comments

@EverybodyKurts
Copy link

Just curious. The explanation is not up yet in the repo.

I realize the software is free, open-source, and provided as is and you absolutely owe me nothing. In fact, I probably owe every developer at Thoughtbot a beer or three (or another beverage of your choice).

I however have coming to lovingly refer to the gem as Factory Girl over the years. Things change and I'll be lovingly referring to the gem as Factory Bot in the next couple of years.

Anyway, thanks for the great work y'all do. My apologies for taking up your time on this trivial issue.

@joshuaclayton
Copy link
Contributor

@KurtRMueller thanks for reaching out! We're in the process of making the appropriate changes, but #921 is a great place to start, and the primary driver for a conversation both with the community and an internal conversation within the company. We'll be making more documentation changes within the repository, as well as a blog post, to outline the drivers behind the change in the coming days. Until then, we appreciate your patience!

And if you're around any of our offices and want to say hi to the local team, don't hesitate to reach out; I'm sure there are plenty who'd be up for grabbing a beer 😄

Because we'll be having this conversation in other areas, I'd encourage you to keep your eyes peeled; in the meantime, I'll close this issue specifically, since the one above is our primary method of communication on GH about the change.

Again, thanks for your patience as we roll these changes out!

@nisevi
Copy link

nisevi commented Jan 3, 2018

@KurtRMueller here: https://robots.thoughtbot.com/factory_bot 👍

Why?

Throughout the years, people have questioned the origins of the name. On a more recent issue, though, more pressing concerns and impressions of the name came to light. Those who were bothered by the name shared a concern that female-gendered names (for software libraries and tools) in male-dominated spaces can be problematic. While the original intent was not meant to focus on gender, which we clarified after this feedback, we knew adding the origin of the name was a stop-gap solution. Constantly citing our original intent made people marginally more comfortable, and we recognized that removing the source of confusion or discomfort (the project name) might address this entirely.

We held a lengthy discussion internally, and while many didn’t find the name concerning, some did, including multiple women and non-binary people within the company and on our client teams. We concluded that, even though not everyone agreed, lack of concern from many shouldn’t prevent the name being changed. Being clever shouldn’t be favored at the expense of others feeling marginalized.

We like the new name, and it fits conveniently with our bot theme as well!

@senguttuvang
Copy link

senguttuvang commented Feb 11, 2018

In layman terms, the term, factory girl looks like projecting women as baby creating machines and hence feminists would have opposed the names, hence the name change.

@bauerd
Copy link

bauerd commented Feb 15, 2018

Thanks for making me search and replace both my Gemfile und application source code just to get rid of the god-damn deprecation warning. Pointless

Edit: Ah, so the Ruby constant is still FactoryGirl, not FactoryBot. Awesome good to know!

@thoughtbot thoughtbot locked as resolved and limited conversation to collaborators Feb 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants