Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lottie: support "skew" property #2262

Closed
hermet opened this issue May 9, 2024 · 1 comment
Closed

lottie: support "skew" property #2262

hermet opened this issue May 9, 2024 · 1 comment
Assignees
@mgrudzinska
Labels
enhancement Improve features lottie Lottie animation
Milestone
0.14

Comments

@hermet
Copy link
Member

hermet commented May 9, 2024

ThorVG is missing support for these two properties:
sk: Skew amount as an angle in degrees
sa: Direction at which skew is applied, in degrees (0 skews along the X axis, 90 along the Y axis)

Please refer: https://lottiefiles.github.io/lottie-docs/concepts/#transform

Entry points to implement:

LottieTransform* LottieParser::parseTransform(bool ddd)  //tvgLottieParser.cpp
bool _updateTransform(LottieTransform* transform, float frameNo, bool autoOrient, Matrix& matrix, uint8_t& opacity, LottieExpressions* exps) //tvgLottieBuilder.cpp
@hermet hermet added enhancement Improve features lottie Lottie animation labels May 9, 2024
@hermet hermet modified the milestone: 0.14 May 9, 2024
mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue May 14, 2024
@mgrudzinska
lottie: implement skew transformation
47d8864 
Added support for skew transformation by
a specified angle around a specified axis.

@issue: thorvg#2262
@mgrudzinska
Copy link
Collaborator

Zrzut ekranu 2024-05-15 o 01 42 00

but I didn't find a viewer supporting skew in repeater

@hermet hermet added this to the 0.14 milestone May 15, 2024
mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue May 15, 2024
@mgrudzinska
lottie: implement skew transformation
9980970 
Added support for skew transformation by
a specified angle around a specified axis.
Applied to layers and shapes, not to repeaters.

@issue: thorvg#2262
mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue May 15, 2024
@mgrudzinska
lottie: implement skew transformation
ab2b133 
Added support for skew transformation by
a specified angle around a specified axis.
Applied to layers and shapes, not to repeaters.

@issue: thorvg#2262
hermet pushed a commit that referenced this issue May 16, 2024
@mgrudzinska @hermet
lottie: implement skew transformation
dc6ddd8 
Added support for skew transformation by
a specified angle around a specified axis.
Applied to layers and shapes, not to repeaters.

@issue: #2262
@hermet hermet closed this as completed May 16, 2024
hermet pushed a commit that referenced this issue May 17, 2024
@mgrudzinska @hermet
lottie: implement skew transformation
0e2dc12 
Added support for skew transformation by
a specified angle around a specified axis.
Applied to layers and shapes, not to repeaters.

@issue: #2262
hermet pushed a commit that referenced this issue May 17, 2024
@mgrudzinska @hermet
lottie: implement skew transformation
dfe8570 
Added support for skew transformation by
a specified angle around a specified axis.
Applied to layers and shapes, not to repeaters.

@issue: #2262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgrudzinska mgrudzinska

Labels
enhancement Improve features lottie Lottie animation
Projects
ThorVG
Status: Done 0.14
Milestone
0.14
Development

No branches or pull requests
2 participants
@hermet @mgrudzinska