Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect fill result when two sub path sharing one edge but has different direction or winding number #1329

Open
RuiwenTang opened this issue Mar 15, 2023 · 2 comments · May be fixed by #1342
Open

Incorrect fill result when two sub path sharing one edge but has different direction or winding number #1329

RuiwenTang opened this issue Mar 15, 2023 · 2 comments · May be fixed by #1342
Assignees
@RuiwenTang
Labels
enhancement Improve features raster Rasterizers (sw/gl/wgpu)

Comments

@RuiwenTang
Copy link
Collaborator 

auto path = tvg::Shape::gen();

  path->moveTo(10, 10);
  path->lineTo(100, 10);
  path->lineTo(10, 100);
  path->close();

  path->moveTo(100, 10);
  path->lineTo(10, 100);
  path->lineTo(100, 100);
  path->close();

  path->fill(0, 255, 0, 255);

The result in thorvg is shown below:
image
@hermet hermet added the enhancement Improve features label Mar 16, 2023
@RuiwenTang
Copy link
Collaborator Author

Any idea about this issue? I might found the root cause, and can provide a PR if needed.

@hermet
Copy link
Member

hermet commented Mar 31, 2023

Sure, pr please!

@RuiwenTang RuiwenTang linked a pull request Apr 1, 2023 that will close this issue
Draft
@hermet hermet modified the milestone: 1.0 Jul 30, 2023
@hermet hermet added the raster Rasterizers (sw/gl/wgpu) label Oct 31, 2023
@hermet hermet assigned hermet and unassigned hermet Nov 5, 2023
@hermet hermet removed their assignment Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RuiwenTang RuiwenTang

Labels
enhancement Improve features raster Rasterizers (sw/gl/wgpu)
Projects
ThorVG
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sw_engine: Fix one pixel blank RuiwenTang/thorvg
2 participants
@hermet @RuiwenTang