fix: added missing conversion to HTML entities

thorsten · Apr 6, 2023 · 514f4df · 514f4df
1 parent 0a4980d
commit 514f4df
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/phpmyfaq/src/phpMyFAQ/Tags.php b/phpmyfaq/src/phpMyFAQ/Tags.php
@@ -31,12 +31,12 @@ class Tags
     /**
      * @var Configuration
      */
-    private $config;
+    private Configuration $config;
 
     /**
      * @var array<int, string>
      */
-    private $recordsByTagName = [];
+    private array $recordsByTagName = [];
 
     /**
      * Constructor.
@@ -59,11 +59,11 @@ public function getAllLinkTagsById(int $recordId): string
         $tagListing = '';
 
         foreach ($this->getAllTagsById($recordId) as $taggingId => $taggingName) {
-            $title = Strings::htmlspecialchars($taggingName, ENT_QUOTES, 'utf-8');
+            $title = Strings::htmlentities($taggingName);
             $url = sprintf('%sindex.php?action=search&amp;tagging_id=%d', $this->config->getDefaultUrl(), $taggingId);
             $oLink = new Link($url, $this->config);
-            $oLink->itemTitle = $taggingName;
-            $oLink->text = $taggingName;
+            $oLink->itemTitle = $title;
+            $oLink->text = $title;
             $oLink->tooltip = $title;
             $tagListing .= $oLink->toHtmlAnchor() . ', ';
         }