Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images with spaces do not show on PDF export #2355

Open
Gregwolf3030 opened this issue Mar 8, 2023 · 3 comments
Open

Images with spaces do not show on PDF export #2355

Gregwolf3030 opened this issue Mar 8, 2023 · 3 comments
Assignees

Comments

@Gregwolf3030
Copy link

Describe the bug
When you try to use the "PDF Version" link to create a PDF of the FAQ article, it works except for images that have spaces in the file names.

To Reproduce
Create an image (png) and save it with a space in the name. Like "This image name has spaces.png". Then create an FAQ article and add that image to the article. The article looks good and it publishes fine. The users can see the article with the image as intended. But if you click the "PDF Version" link, the PDF will not contain the image. If you save the same image as "This_image_name_has_no_spaces.png" and add it just like before. The PDF will include the image.

Expected behavior
The PDF creation should account for images that may have spaces in them and take the appropriate action so those images are included in the PDF just like all other images.

phpMyFAQ (please complete the following information):

  • phpMyFAQ version: 3.1.11
  • PHP version: 8.0.22
  • Database: MariaDB 10.3.32 (MySQL)

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome
  • Version: Version 110.0.5481.178 (Official Build) (64-bit)
@thorsten thorsten self-assigned this Mar 9, 2023
@thorsten thorsten added the Bug label Mar 9, 2023
@thorsten thorsten added this to the 3.1.12 milestone Mar 9, 2023
@thorsten
Copy link
Owner

thorsten commented Mar 9, 2023

I can confirm the issue, I have check why this happens in the bundled library.

@thorsten thorsten modified the milestones: 3.1.12, 3.1.13 Mar 11, 2023
@Gregwolf3030
Copy link
Author

What is the update on this issue? I see it has been pushed back to a later version. Is there an ETA for that later version? The reason I ask is because I need to do something about this soon. If the fix isn't going to come out soon, I will need to create a script to go through all the FAQ's and rework the links and then rework the file names. Then put out a policy so file names like that are not created in the future (which of course will be promptly ignored and the problem will continue). Don't want to have to do that if I don't have to.

@thorsten
Copy link
Owner

Currently I have no fix, that's why I moved it to the 3.1.13 release.

@thorsten thorsten removed this from the 3.1.13 milestone Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants