Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision Log Package Filtering #93

Open
rdurham285 opened this issue Oct 4, 2022 · 5 comments · May be fixed by #99 or #100
Open

Decision Log Package Filtering #93

rdurham285 opened this issue Oct 4, 2022 · 5 comments · May be fixed by #99 or #100
Labels
feature New feature or request

Comments

@rdurham285
Copy link

Feature Request

Feature Suggestion

It would be of great value if we could get some views that were filtered down by a given package.

Context

Managing a long lived monorepo with lots of ADRs could grow cumbersome. We are also adopting ADR for decision making for our enterprise where we intend to model certain business and technical areas as packages, where it would be valuable to view those decision areas separately from the global adr population.

Possible Implementation

On the left side in the visual representation of the decision log, a drop down or method of picking a package that filters it down to the decisions in the package would be one way to implement this.

@rdurham285 rdurham285 added the feature New feature or request label Oct 4, 2022
@qtzar
Copy link

qtzar commented Nov 15, 2022

I would also love to see this feature added.
The possible implementation that is outlined above of a dropdown would work well.

tylerhubert added a commit to tylerhubert/log4brains that referenced this issue Jan 20, 2023
@tylerhubert
Copy link

I wanted this functionality as well, so I've implemented a simple version of this request in #99. Please provide feedback if you would like!

@qtzar
Copy link

qtzar commented Jan 20, 2023

@tylerhubert I just wrapped up very similar code in my fork to add this functionality also. I just couldn't get it to commit due to a typescript listing issue I'm still trying to resolve.

@tylerhubert
Copy link

@qtzar, I got around that by doing --no-verify on the commit. It seems like yarn lint will pass for me, but the husky pre-commits won't due to libraries (airbnb related I believe) that need to be updated.
I guess we can see if @thomvaill is ok with that or not. :) I just opened up 3 PRs in the last day this same way, so I might have some rework to do if we need to get that handled.

@qtzar qtzar linked a pull request Jan 23, 2023 that will close this issue
@tylerhubert
Copy link

I suggest going with @qtzar's changes. :) The UI is formatted much nicer than mine and has more features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
3 participants