Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootswatch themes 3.3.7 with web-font fails to compile with less 3.0.4 #841

Closed
kitsguru opened this issue Jun 12, 2018 · 3 comments
Closed

Comments

@kitsguru
Copy link

Trying to recompile the 3.3.7 less themes with less 3.0.4 fails with the following error:

/themes/cosmo/bootswatch.less: [L10:C0] variable @path is undefined
Warning: Error compiling www/_src/less/theme-cosmo.less Use --force to continue.

Code in question is:

@web-font-path: "https://fonts.googleapis.com/css?family=Roboto:400,700";

.web-font(@path) {
  @import url("@{path}");
}
.web-font(@web-font-path);

I can't see why this would fail or why @path is now considered undefined. Any ideas would be appreciated.

@thomaspark
Copy link
Owner

thomaspark commented Jun 13, 2018

Related to less/less.js#3188?

Can you try @import (css) url("@{path}"); and see if it fixes it for you?

@kitsguru
Copy link
Author

kitsguru commented Jun 13, 2018

Bingo - that did it. Are you going to fix the various themes. I am slowing converting to Bootstrap 4 but not ready yet. Also I see that they are going to do a bootstrap 3.4.

@thomaspark
Copy link
Owner

Pushing a fix for all v3 themes now. It'll be updated for the website now and for packages next time the version number ticks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants