Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a compatible Firefox version #15

Open
thomaschampagne opened this issue Feb 19, 2015 · 43 comments
Open

Create a compatible Firefox version #15

thomaschampagne opened this issue Feb 19, 2015 · 43 comments

Comments

@thomaschampagne
Copy link
Owner

No description provided.

@Eskorpio
Copy link

I hope a version for Firefox in the future. Thanks.

@praveentiru
Copy link
Contributor

@thomaschampagne Assign this to me. I want to investigate on how to achieve this after closing #10.

@thomaschampagne
Copy link
Owner Author

thomaschampagne commented Jun 2, 2016

@praveentiru Haha you're on top ! :)

Github don't dont allow me to assign you on this :/ wtf.

I looked about the extension migration process to FF. It's pretty hard !!!

As a workaround to give stravistix "for all" i thinked about cross OS standalors stravistix with "Node Web kit @ https://github.com/nwjs/nw.js/". Associated ticket is https://github.com/thomaschampagne/stravistix/issues/175. For example the well know popcorn time project and theirs forks are based on node webkit.

@praveentiru
Copy link
Contributor

@thomaschampagne I don't know if you have looked at new development from Firefox. Firefox is planning to release WebExtensions whose architecture seems very similar to Chrome's extensions architecture.

The first stable release is expected in Firefox 48 (which should come out in August). With little changes we might able to provide this as add-on for Firefox

@thomaschampagne
Copy link
Owner Author

@praveentiru Woow sounds goods, Things can change then !! I rode firstfruits of that from an old bill (https://hacks.mozilla.org/2015/10/porting-chrome-extensions-to-firefox-with-webextensions/) but moreexperimental...

I will deep at a closer look into your given infos ! Thanks

@praveentiru
Copy link
Contributor

praveentiru commented Jun 25, 2016

Areas that have to be addressed:

  • Firefox does not support sync storage as of today

Comment to be edited as new areas are discovered

@aurelg
Copy link

aurelg commented Sep 28, 2017

It seems there's some support of sync storage implemented since Firefox 53 (April 19, 2017), see release note.

@rmv125
Copy link

rmv125 commented Dec 6, 2017

The firefox 57 is released, and supports WebExtentions.

@thomaschampagne
Copy link
Owner Author

@rmv125 Did you try a build of stravistix on it?

@tonio
Copy link

tonio commented Dec 7, 2017

I just tried with Chrome Store Foxified. I can convert the app & install it, but it fails when I try to sync:

screenshot from 2017-12-07 08-57-36

@rmv125
Copy link

rmv125 commented Dec 8, 2017

@thomaschampagne I didn't tried converting it yet, but mozilla extension test says that it's possible.
https://www.extensiontest.com/test/f85452f0-dc36-11e7-9408-1de26b462a9c

@rmv125
Copy link

rmv125 commented Dec 8, 2017

Also, here is the list of incompatibilities:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Chrome_incompatibilities
Would be nice if you look on it.

@rmv125
Copy link

rmv125 commented Dec 8, 2017

Tried to install:
ff

@binaryanomaly
Copy link

One manifest error less now. But it's not synching. Are we far from having it working in Firefox?

image

@thomaschampagne
Copy link
Owner Author

We are not far. I have this in sight. Some other technical stuff must be done before like switch from systemjs to webpack for the core plugin. It will be easier to migrate to FF.

I dropped one today: removed old app. So this has not to be migrated to work with FF

@MQuaresma
Copy link

@thomaschampagne What is the status on this? I've forked your repo to work on this issue if it's still useful/needed

@MQuaresma
Copy link

@thomaschampagne I'm going to try and start working on this this week, can tou assign it to me? I'll report my progress

@thomaschampagne
Copy link
Owner Author

@MQuaresma damn i can't assign you! wtf :/

@MQuaresma
Copy link

It might be because I'm not yet a contributor, I'm not sure

@thomaschampagne
Copy link
Owner Author

@MQuaresma Should be ok once you accepted the invite ;)

@MQuaresma MQuaresma self-assigned this Aug 8, 2018
@MQuaresma
Copy link

@thomaschampagne Thanks, just did ;) Getting to work today hopefully

@thomaschampagne
Copy link
Owner Author

@MQuaresma Perfect !! I let you create a branch from develop named like feature/15-firefox-support or the name you want :)

Thanks in advance for you help !! Support of firefox could be awesome for lot of people!

@thomaschampagne
Copy link
Owner Author

@MQuaresma Did you start something on? :)

@MQuaresma
Copy link

@thomaschampagne Yeah, sorry for the slow progress, I've been a little bit busy lately with an internship I'm enrolled in. I've been reading up on the WebExtensions API and the Chrome Incompatibilities article on MDN documentation.

@thomaschampagne
Copy link
Owner Author

thomaschampagne commented Aug 19, 2018 via email

@cedricdelpoux
Copy link

@thomaschampagne
Copy link
Owner Author

Is this working properly? (Can't test... i'm in vacation with smartphone only)

@cedricdelpoux
Copy link

Yes it seems to work! I'm using it right now.

But I'm a very new strativix user so I can't check everything because I don't know well every feature.
I could synchronize all my activities.
screen shot 2018-08-23 at 10 50 05

@aurelg
Copy link

aurelg commented Aug 23, 2018

It seems to work here too. Three attempts were required to synchronize >1300 activities. 👍

@cedricdelpoux
Copy link

Yeah I tried multiple times too

@thomaschampagne
Copy link
Owner Author

thomaschampagne commented Aug 23, 2018 via email

@tonio
Copy link

tonio commented Aug 23, 2018

Tried it & looks to work fine. @thomaschampagne yes, extended stats for activities is functional too.

@cedricdelpoux
Copy link

Yes, it's working on a Strava activity page too.

Here is the fork repo: https://github.com/CodeNKasch/stravistix

There is no more commits

@cedricdelpoux
Copy link

I found it. This is the firefox feature branch: https://github.com/CodeNKasch/stravistix/tree/feature/firefox

@thomaschampagne
Copy link
Owner Author

thomaschampagne commented Aug 23, 2018

@MQuaresma That upper post might help you :)

@thomaschampagne
Copy link
Owner Author

@xuopled Nice found !

@cedricdelpoux
Copy link

I just opened an PR to open the discussion and reach the author: https://github.com/thomaschampagne/stravistix/pull/648

@CodeNKasch
Copy link

Hey there, i will Clean my fork and create auf Patch for you. This way it should be easyer to apply to your repository. Only thing thats not working atm is the Autoclose of the sync dialog.

It will take some time since im fully scheduled atm.

Cheers, Karl

@thomaschampagne
Copy link
Owner Author

thomaschampagne commented Aug 23, 2018

@CodeNKasch Great !!

Take your time. This ticket has more than 3 years...

Keep us in touch

Thanks for the work performed !

@MQuaresma
Copy link

@CodeNKasch let me know if you need anything and I'll try and help out

@CodeNKasch
Copy link

I updated to the new version but dont had the time to clean it.

@MQuaresma
Copy link

MQuaresma commented Mar 23, 2019

@thomaschampagne @CodeNKasch What is the status on this issue? There doesn't seem to be a working version of Elevate on Firefox, shall I take this one on again?

@Eskorpio
Copy link

I've been waiting for the Firefox version for a long time, is it expected to be released in the next few months?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants