Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of TLDs doesn't seem to be updating globally #145

Open
critsmet opened this issue May 6, 2022 · 1 comment
Open

List of TLDs doesn't seem to be updating globally #145

critsmet opened this issue May 6, 2022 · 1 comment

Comments

@critsmet
Copy link

critsmet commented May 6, 2022

If I understand correctly, simply running the command npm install --save tldjs --tldjs-update-rules should update the list of tlds globally.

I'm working on a tool that uses tld.js to check validity of email addresses, we have had several customers writing in being unable to sign up with their domains.

In my local dev environment, I saw that tldExists was returning false for a specific domain. After running the above command, the same argument began to return true, so I imagined the list of tlds had been updated successfully.

However the value continues to return false in staging and production. Am I missing something here?

Thanks!

@remusao
Copy link
Collaborator

remusao commented May 6, 2022

Hi @critsmet,

I believe you might need to run this command after installing your dependencies in your staging and production environment as well (the command might need to be executed explicitly, maybe as a postinstall hook in your project?).

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants