Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide official browser compatible version in the releases #134

Open
ray-lothian opened this issue Jun 27, 2019 · 4 comments
Open

Provide official browser compatible version in the releases #134

ray-lothian opened this issue Jun 27, 2019 · 4 comments

Comments

@ray-lothian
Copy link

I know that we can use https://wzrd.in/standalone/tldjs, but there is no version control. We need something that is persistent and can be referenced, so that it can be checked in the future (MD5 for instance).

@remusao
Copy link
Collaborator

remusao commented Jun 27, 2019

Hi @ray-lothian,

Did I understand correctly that you would like to have tld.js bundle both the rules (public suffix) and the source code at once so that it can be versioned. If so, I think it's important to point out that there is a trade-off here that not everyone is willing to take:

  1. With tld.js you get automatic updates of the rules when you install and sub-sequentially in postinstall hooks. This ensures that your project always gets the latest version of the rules (which are updated continuously with new domains/suffixes) even when there is no new release of the package on npm.
  2. You can bundle the rules, which means that the version of the package corresponds to the version of the rules. The trade-off is that you need to update the dependency to get updated rules, and you need to trust the project to release a new version for every new rule update. There are libraries offering this trade-off as well.

Hope that helps,

@ray-lothian
Copy link
Author

Right but there are some cases where an external library may need to be verified later.

For instance, in my case, I've just started using this library in my browser extension. Note that browser extensions do not allow remote resources. So anyway I need to download the latest version and pack it with my extension. The problem is that there is no reliable way to check the original library to make sure it is not being modified. This is a requirement that extension reviewers check on each update; https://developer.mozilla.org/en-US/Add-ons/Third_Party_Library_Usage

If we have an official bundle then I can point to the particular version and it is really easy for the reviewer to verify.

@remusao
Copy link
Collaborator

remusao commented Jun 27, 2019

I understand. Than I think this is currently not possible with tld.js unfortunately.

@thom4parisot
Copy link
Owner

thom4parisot commented Aug 24, 2021

If i understand well, you’d like to reference Tld.js within your package.json and to import it within your extension codebase? Or you’d like to fetch a version with all the dependencies + rules to bundle it within your extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants