Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current master README misleading (isValidHostname) #133

Open
ctavan opened this issue Apr 2, 2019 · 0 comments
Open

Current master README misleading (isValidHostname) #133

ctavan opened this issue Apr 2, 2019 · 0 comments

Comments

@ctavan
Copy link

ctavan commented Apr 2, 2019

The current master README on the front-page of this github repo is misleading with respect to isValidHostname as it points to unreleased changes that deprecate isValid and introduce isValidHostname… However those changes are still unreleased.

So if users of the latest tldjs@2.3.1 come to this repo and check out the readme they might easily get confused.

How about releasing a new version that contains isValidHostname?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctavan