Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The value must be a string #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lqzhgood
Copy link

@lqzhgood lqzhgood commented Feb 7, 2019

fix #131

Copy link
Collaborator

@remusao remusao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! You might need to remove some of the test-cases which covered non-string values to make this green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse undefined / null => isValid:true ?
2 participants