Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for private repos in build and other tasks #68

Open
alok87 opened this issue Jul 28, 2022 · 5 comments · May be fixed by #72
Open

Support for private repos in build and other tasks #68

alok87 opened this issue Jul 28, 2022 · 5 comments · May be fixed by #72
Assignees

Comments

@alok87
Copy link

alok87 commented Jul 28, 2022

GOPRIVATE needs to be set if there are private repos that needs to be pulled
Also, the container would need some kind of GIT_TOKEN or ~/.netrc file to be able to pull private dependencies

Pull fails at present since these are not found

$ make build

fatal: could not read Username for 'https://github.com': terminal prompts disabled1

@thockin
Copy link
Owner

thockin commented Jul 28, 2022

Why can't you just:

export GOPRIVATE=xyz
make

or

GOPRIVATE=xyz make

or

make GOPRIVATE=xyz

?

@alok87
Copy link
Author

alok87 commented Jul 28, 2022

It does not work only by adding variable GOPRIVATE, the container expects .netrc to be present which is not mounted, on mounting .netrc with git creds in all docker run commands it works!

@thockin
Copy link
Owner

thockin commented Jul 28, 2022 via email

@alok87
Copy link
Author

alok87 commented Aug 22, 2022

I will get back with a PR soon. 😨 (oh it need to get back ~edited)

@alok87 alok87 linked a pull request Aug 26, 2022 that will close this issue
@alok87
Copy link
Author

alok87 commented Dec 13, 2022

In my local i am using ~./.netrc as a mount. But people use SSH also for authenticating with git. Need a generic solution. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants