Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC2 comes before alpha5 in terms of semver #191

Open
dozoisch opened this issue Jan 27, 2016 · 2 comments
Open

RC2 comes before alpha5 in terms of semver #191

dozoisch opened this issue Jan 27, 2016 · 2 comments
Labels
Milestone

Comments

@dozoisch
Copy link

Semver compares prelease version in ASCII. Turns out RC is smaller than alpha. With http://semver.npmjs.com/ you can see that writing a range like ~2.0.0-RC2 selects RC2 and alpha 1 to 5.

Just changing the label to rc in lowercase would fix it.

http://semver.org/#spec-item-11

When major, minor, and patch are equal, a pre-release version has lower precedence than a normal version. Example: 1.0.0-alpha < 1.0.0. Precedence for two pre-release versions with the same major, minor, and patch version MUST be determined by comparing each dot separated identifier from left to right until a difference is found as follows: identifiers consisting of only digits are compared numerically and identifiers with letters or hyphens are compared lexically in ASCII sort order.

@aseemk
Copy link
Member

aseemk commented Jan 28, 2016

Nice catch!

I'm a bit stretched thin right now, but at the top of my list with this project is to simply finish the docs and merge the v2 branch, making it official. So no more RC/rc etc. at that point anyway.

If I don't get to that soon, I'll update RC to rc. =) Thanks again!

@aseemk aseemk added the bug label Jan 28, 2016
@aseemk aseemk added this to the v2 redesign milestone Jan 28, 2016
@dozoisch
Copy link
Author

awesome :) thanks a lot for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants