Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't define PortableCommandAlias when creating a nested installer #51

Open
taki-eddine-47 opened this issue Apr 14, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@taki-eddine-47
Copy link

Describe the bug:
When creating a zip package, winget gives the two options for NestedInstallerFiles, RelativeFilePath and PortableCommandAlias, wingetty doesn't provide the second option.

Example: https://github.com/microsoft/winget-pkgs/blob/master/manifests/s/Stenzek/DuckStation/0.1.6280/Stenzek.DuckStation.installer.yaml

To Reproduce:
Steps to reproduce the behavior:

Expected behavior:
Ability to define PortableCommandAlias.

Screenshots
image

General Information:

  • OS: Docker
  • Browser: any
  • WinGetty: 1.0.0

Additional context:
Just quick search in code.
In the form, you can find only use of RelativeFilePath: https://github.com/thilojaeggi/WinGetty/blob/115adecb9b6b7afd6c56bb29e82126ef0adb2a78/app/forms.py#L108C40-L108C61
But the model support the second option:

"PortableCommandAlias": nested_installer_file.portable_command_alias,

@taki-eddine-47 taki-eddine-47 added the bug Something isn't working label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant