-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support common identifiers #50
Comments
I would love to help you here, if you can maybe explain why you changed this with 8f1cdbf |
Hi marci4 Iirc this was done in an attempt to remove special characters from the Identifier as these would get stripped later by "secure_filename" in the backend. Although I think "+" amongst others should be safe from this and the regex could be changed. |
Works after updating to the current dev. |
Just fyi, it is not recommended to use the dev branch as it will break things. |
Sorry I have to reopen the issue. |
Is your feature request related to a problem? Please describe.
Most identifiers in the current winget repository contain "special" characters, which will currently be removed when adding a package via the UI (https://github.com/thilojaeggi/WinGetty/blob/main/app/templates/modals/add_package.j2#L63)
Describe the solution you'd like or how it could be implemented
Support common identifiers containing ("+","-",".""_")
Additional context
Examples:
Notepad++.Notepad++
ndd.Notepad--
Zheguisoft.zg_mdm
The text was updated successfully, but these errors were encountered: