Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support common identifiers #50

Open
marci4 opened this issue Apr 11, 2024 · 6 comments
Open

Support common identifiers #50

marci4 opened this issue Apr 11, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@marci4
Copy link

marci4 commented Apr 11, 2024

Is your feature request related to a problem? Please describe.
Most identifiers in the current winget repository contain "special" characters, which will currently be removed when adding a package via the UI (https://github.com/thilojaeggi/WinGetty/blob/main/app/templates/modals/add_package.j2#L63)

Describe the solution you'd like or how it could be implemented
Support common identifiers containing ("+","-",".""_")

Additional context
Examples:
Notepad++.Notepad++
ndd.Notepad--
Zheguisoft.zg_mdm

@marci4 marci4 added the enhancement New feature or request label Apr 11, 2024
@marci4
Copy link
Author

marci4 commented Apr 11, 2024

I would love to help you here, if you can maybe explain why you changed this with 8f1cdbf

@thilojaeggi
Copy link
Owner

Hi marci4

Iirc this was done in an attempt to remove special characters from the Identifier as these would get stripped later by "secure_filename" in the backend. Although I think "+" amongst others should be safe from this and the regex could be changed.

@thilojaeggi
Copy link
Owner

Fixed in:
9870372
0bb9ccb
7dcc8f1

@marci4
Copy link
Author

marci4 commented Apr 16, 2024

Works after updating to the current dev.
Thank you @thilojaeggi for the quick fix.

@marci4 marci4 closed this as completed Apr 16, 2024
@thilojaeggi
Copy link
Owner

Just fyi, it is not recommended to use the dev branch as it will break things.

@marci4 marci4 reopened this Apr 17, 2024
@marci4
Copy link
Author

marci4 commented Apr 17, 2024

Sorry I have to reopen the issue.
It is still not possible to upload a package name with an identifier like "Microsoft.DotNet.SDK.8"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants