Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some unescape() are missing #39

Open
sigmaeo opened this issue Mar 20, 2018 · 1 comment
Open

some unescape() are missing #39

sigmaeo opened this issue Mar 20, 2018 · 1 comment

Comments

@sigmaeo
Copy link

sigmaeo commented Mar 20, 2018 •
edited

There is no unescape in:
readStringArg()
copyStringArg()
compareStringArg()

So you got (with ID=1) from readStringArg() for the transmitted string:

1,Hello\,World\;Or what?;

"Hello\,World\;Or what?"
Of course you can unescape this no in user sketch, but I think, this is not as it should be?
sigmaeo added a commit to sigmaeo/Arduino-CmdMessenger that referenced this issue Mar 20, 2018
@sigmaeo
some unescape() are missing (issue thijse#39)
f284382
@sigmaeo sigmaeo mentioned this issue Mar 20, 2018
Open
@sigmaeo
Copy link
Author

sigmaeo commented Mar 20, 2018

I fixed this in my fork and it is included in poll #37.

Now you got:
"Hello, World; Or what?"

MatthiasKunnen added a commit to MatthiasKunnen/Arduino-CmdMessenger that referenced this issue Aug 3, 2020
@MatthiasKunnen
Apply improvements by @sigmaeo
a0d2340 
Changes applied from:
<https://github.com/sigmaeo/Arduino-CmdMessenger/tree/eb8e413f1313dbf5012ae6b751a6246b41a4e5ad>

- Fix startCommand was not initialized
  not a problem on arduino, but with C++-Builder on Windows
- Add missing unescape() are missing (issue thijse#39)
- Make readBin() safe for less received bytes (see issue thijse#38)
- Replace Serial.print() with comms->print()
@gyssels gyssels mentioned this issue Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sigmaeo