Code Review

[regmicmahesh]

1

When you define routes like this, the second parameter is the handler.

aot-api/index.js

Lines 24 to 26 in d66ee8e

	app.get('/', (req, res) => {
	res.render('index', {amount: numOfQuotes()})
	})

But you have a separate file called handlers.js which isn't directly handling the response. It'd be better if you did something like this.

 app.get('/', homepageHandler)

and, all the logic of handling the route goes inside the homepageHandler.

2

aot-api/index.js

Line 40 in d66ee8e

port = process.env.PORT || 3000

Never ever do this when you build an application.

For example, let me consider you're hosting this application in a server and the server expects you to run your app in port 4050. Now, your app will be working perfectly fine if you forgot to provide the value of PORT . But you'll not be able to access since you've a defeault value of 3000 instead of 4050. Throw a error instead when value is not provided.