Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The Preference Bundle template adds a load command that exposes developer's username and working directory #720

Open
limneos opened this issue Apr 13, 2023 · 0 comments · May be fixed by #721

Comments

@limneos
Copy link

limneos commented Apr 13, 2023

What are the steps to reproduce this issue?

  1. Make new project
  2. Add a preference bundle subproject to the project using nic.pl - preference-bundle option
  3. compile etc.

What happens?

The resulting PreferenceBundle binary self load dylib command includes the working directory of the developer's computer, including the account username.

What were you expecting to happen?

The resulting binary load dylib command should either use @rpath or since it's not important, use any other path other than the real working directory on the developer's computer.

Paste any relevant logs, error output, etc.

iphone: root# otool -L /Library/PreferenceBundles/SubstitutePrefs.bundle/SubstitutePrefs 

SubstitutePrefs.bundle/SubstitutePrefs (architecture arm64):
	/Users/gitlab/builds/JvkhZZgY/0/sbingner/substitute-package/.theos/obj/arm64/SubstitutePrefs.bundle/SubstitutePrefs (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0)
	/System/Library/Frameworks/Foundation.framework/Foundation (compatibility version 300.0.0, current version 1444.12.0)
	/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation (compatibility version 150.0.0, current version 1443.0.0)
	/System/Library/Frameworks/UIKit.framework/UIKit (compatibility version 1.0.0, current version 3694.4.18)
	/System/Library/PrivateFrameworks/Preferences.framework/Preferences (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.0.0)

Additional context

No response

What OS are you seeing the problem on?

macOS

What OS version does it have installed?

13.1

What toolchain and version are you using?

Xcode 12

Which SDK version are you using?

iOS 14

What OS is your client device running?

iOS

What OS version does it have installed?

14

Which device model is it?

iPhone 12

Which jailbreak is it using (if relevant)?

No response

@L1ghtmann L1ghtmann linked a pull request Apr 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant