Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent bundle absolute LC_ID_DYLIB #721

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Prevent bundle absolute LC_ID_DYLIB #721

wants to merge 6 commits into from

Conversation

L1ghtmann
Copy link
Member

@L1ghtmann L1ghtmann commented Apr 14, 2023 •
edited

What does this implement/fix? Explain your changes.

Specifies runtime location as install_name for bundles when linking to avoid using an absolute path

Does this close any currently open issues?

Appears to resolve #720

Any relevant logs, error output, etc?

Any other comments?

Before:

          cmd LC_ID_DYLIB
      cmdsize 96
         name /home/lightmann/vinyl/.theos/obj/arm64/VinylPrefs.bundle/VinylPrefs (offset 24)

After:

          cmd LC_ID_DYLIB
      cmdsize 88
         name /var/jb/Library/PreferenceBundles/VinylPrefs.bundle/VinylPrefs (offset 24)

Where has this been tested?

Operating System: …

Linux (WSL) + iP7 iOS 15.4.1 palera1n

Platform: …

Target Platform: …

Toolchain Version: …

SDK Version: …

@L1ghtmann L1ghtmann changed the title Use relative install_name path for bundles (prevents absolute LC_ID_DYLIB) Prevent bundle absolute LC_ID_DYLIB Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uroboro uroboro uroboro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@L1ghtmann @uroboro