Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Maintainer script validation #593

Open
absidue opened this issue May 11, 2021 · 1 comment
Open

[Feature request] Maintainer script validation #593

absidue opened this issue May 11, 2021 · 1 comment

Comments

@absidue
Copy link

absidue commented May 11, 2021

Preamble
When Procursus switched the default shell from bash to dash, numerous packages failed to install and uninstall. This was due to the maintainer scripts in those packages being created with the assumptions that the default shell would be bash and that /bin/sh would be symlinked to bash.

Feature request
To help reduce future issues, I propose having some validation of the maintainer scripts in the DEB packaging in Theos. The most basic validation could include a check for a shebang and possibly a check for common bashisms such as if [[ in scripts with a #!/bin/sh shebang.

@L1ghtmann
Copy link
Member

May be worth looking into a pre-existing tool/script (e.g., checkbashisms) to run checks before dm.pl runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants