Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider support for pulling multiple tools out of one archive or pkg #24

Open
mark-thm opened this issue Mar 22, 2024 · 0 comments
Open

Comments

@mark-thm
Copy link
Contributor

mark-thm commented Mar 22, 2024

Sometimes, several applicable tools come packaged in the same archive.

@andyscott mentioned in #22 (comment):

As a heads up since you're going to be thinking about the schema: I was planning to open another PR to add add support for multiple binaries from a single archive. E.g. the envtest suite from https://kubebuilder-tools.storage.googleapis.com/kubebuilder-tools-1.27.1-darwin-amd64.tar.gz contains:

kubebuilder/bin/etcd
kubebuilder/bin/kube-apiserver
kubebuilder/bin/kubectl

Currently, our environment repos have a layout of something like:

tools/{tool_name}/{os}_{cpu}_archive/
tools/{tool_name}/{os}_{cpu}_executable -> symlink to a file in archive

We could consider updating the layout to something like:

archives/{archive_alias}/
archives/BUILD.bazel # export all dirs
tools/{tool_name}/{os}_{cpu}_executable -> symlink to a file in archive

Which would better support this particular use-case.

It's not obvious whether {archive_alias} should be the filename, filename+sha256, or a user-supplied value in the lockfile. We could add a new 'reference-archive' binary kind that depends on the alias, or we could tie together archives automatically. The specifics here need a bit more of a plan, but something of this shape is probably a thing we'd be willing to adopt in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant