Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of kopt implementation #65

Open
FarnazH opened this issue Mar 7, 2021 · 1 comment
Open

Improve efficiency of kopt implementation #65

FarnazH opened this issue Mar 7, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@FarnazH
Copy link
Member

FarnazH commented Mar 7, 2021

Actually, why make a permutation matrix (mostly zeros and ones) and multiply by A (cost of O(n^3)). You can directly compute A with permuted rows/columns, then compute the error in (permuted) A. This has cost O(n^2) (computing the error) instead of O(n^3). IF the error is reduced, you can return the permutation, or even the permutation matrix (which can be constructed at the very end).

Originally posted by @PaulWAyers in #62 (comment)

@PaulWAyers
Copy link
Member

This supersedes #79 which I closed.

@FarnazH FarnazH added the enhancement New feature or request label Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants