Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing testing, test_psdp_woodgate_non_full_rank #190

Open
FanwangM opened this issue Sep 3, 2022 · 11 comments · May be fixed by #191
Open

Failing testing, test_psdp_woodgate_non_full_rank #190

FanwangM opened this issue Sep 3, 2022 · 11 comments · May be fixed by #191

Comments

@FanwangM
Copy link
Collaborator

FanwangM commented Sep 3, 2022

Can you check why the testing is failing for https://github.com/theochem/procrustes/runs/8172507556?check_suite_focus=true? I have tried to rerun the testing and it didn't help. I don't know if it's Scipy or Numpy version related or operating system related. The tests work before we merge the PR.

Thank you. @banrovegrie

@banrovegrie
Copy link
Member

Yeah I will fix this

@banrovegrie
Copy link
Member

It's weird how the issue doesn't exist at all for python3.8+ as well as python3.6-.

@banrovegrie banrovegrie linked a pull request Sep 5, 2022 that will close this issue
@FanwangM
Copy link
Collaborator Author

FanwangM commented Sep 5, 2022

It's weird how the issue doesn't exist at all for python3.8+ as well as python3.6-.

True. I think it's Windows OS related only as I have tested for many times.

@banrovegrie
Copy link
Member

Anyways I think #191 fixes it?

@FanwangM
Copy link
Collaborator Author

FanwangM commented Sep 6, 2022

I have tested it again on a windows machine with the same working environment (Python 3.7.9 and the same numpy and scipy version) and it works. Also, the current running of tests, https://github.com/theochem/procrustes/runs/8197877947?check_suite_focus=true, works. So, I would guess that's related to the hardware?

What do you think?
@PaulWAyers @banrovegrie

@PaulWAyers
Copy link
Member

Seems strange, but not implausible, to me. I guess we can specify the hardware in the install?

@banrovegrie
Copy link
Member

Maybe, but will that lead to a precision issue as big as 3 decimal places?

@banrovegrie
Copy link
Member

Let's have a meet and fix the currently present testing issues. Will anytime on the 10th of October (or later) work?

@FanwangM
Copy link
Collaborator Author

FanwangM commented Oct 5, 2022

What's the time difference between us now (your current location and Toronto)? @banrovegrie

@banrovegrie
Copy link
Member

I got back to college yesterday. So now the time gap is around 9 hours. But I will mostly be available till late at night (India time) which should be around 3:30 PM Toronto time.

@banrovegrie
Copy link
Member

@FanwangM any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants