Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Import Theme Configuration? #23

Open
ghost opened this issue Apr 30, 2016 · 13 comments
Open

Feature Request: Import Theme Configuration? #23

ghost opened this issue Apr 30, 2016 · 13 comments

Comments

@ghost
Copy link

ghost commented Apr 30, 2016

I'd like to request if possible an import theme button that can import the existing GTK3 based configurations in favor of an old theme.

Or something similar

I don't know if it's possible but please consider this as a suggestion.

Thanks

@actionless
Copy link
Member

I did not understood clearly what does that mean, to import the colorscheme from another GTK theme?

@ghost
Copy link
Author

ghost commented May 3, 2016

Yes exactly! I noticed the configurations are modified on GTK Theme Folder.

I believe that the tool you are using is based on Numix, and hopefully you probably add this enhancement in a future release to import the colorscheme from another GTK Theme as you said. 👍

@actionless
Copy link
Member

now there is a import plugin api feel free to implement it as plugin

ex.: https://github.com/themix-project/oomox/tree/master/plugins

@tnilzon
Copy link

tnilzon commented Sep 20, 2018

Help needed:
How to implement this plugin in Oomox?
(I am on Majaro gnome, and installed Oomox via Pamac.)

@actionless
Copy link
Member

@tnilzon you can take a look on this really tiny plugin which takes colors from .yml palettes from base16 project and imports them as oomox themes:

https://github.com/themix-project/oomox/tree/master/plugins/import_base16

@actionless
Copy link
Member

however, i think, it will be nice to add "import" button in GUI (because now for importing something you need to copy it to ~/.config/oomox/colors)

@actionless actionless reopened this Sep 20, 2018
@tnilzon
Copy link

tnilzon commented Sep 20, 2018

Yes, an "Import" button would be the best, great if you could implement that/ thanks!

@actionless
Copy link
Member

actionless commented Sep 20, 2018

but, just to clarify, i am going to implement only "Import" button itself, which will be used by import plugins (#161)

so if you want to import the colors from a new source you still need to implement that plugin itself. so far supported only importing colors from base16 and from images (also there is import of Xresources palette done implicitly when using xresources color themes but it also going to be refactored to be a plugin)

@tnilzon
Copy link

tnilzon commented Sep 21, 2018

Would this be possible: Press the 'Import' button -> Select a gtk theme -> the selected theme is then imported and can be edited as a new theme (as the "default" pre-installed Oomox themes) ?

@actionless
Copy link
Member

actionless commented Sep 21, 2018

yes, that would be possible

you can already start writing a plugin because you won't need to modify it to work together with that button:

https://github.com/themix-project/oomox/blob/master/plugins/import_base16/oomox_plugin.py#L106

as you can see in this example, plugin just reads some theme from a filepath, it doesn't know if it was opened from ListView or from FileOpenDialog

@tnilzon
Copy link

tnilzon commented Sep 21, 2018

Well I am afraid I am not skilled to write any plugin by myself. So I will have to wait for it to be implemented (the button and the plugin).
Thanks anyway!

@actionless
Copy link
Member

actionless commented Sep 21, 2018

rather than waiting you could just use color picker (eyedropper tool) in oomox when selecting the colors (it's available when you opening palette editor by clicking on button near each color) and pick the colors from the theme of your choice

@tnilzon
Copy link

tnilzon commented Sep 21, 2018

OK, Thanks the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants