Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to toggle link preview per channel #4805

Open
ThatLurker opened this issue Dec 5, 2023 · 5 comments
Open

Ability to toggle link preview per channel #4805

ThatLurker opened this issue Dec 5, 2023 · 5 comments
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.

Comments

@ThatLurker
Copy link

Feature Description

Would be nice to be able to turn off link preview on some channels, but still have it on others.
Could maybe be as an option bellow the mute channel.

@ThatLurker ThatLurker added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Dec 5, 2023
@ThatLurker ThatLurker changed the title Ability to turn link preview off per channel Ability to toggle link preview per channel Dec 5, 2023
@ThatLurker
Copy link
Author

ThatLurker commented Dec 5, 2023

The main issues arises when multiple thelounge users make requests to a link which might be a rate limited or just has a bad server and in doing so they "ddos" the website.
A per channel toggle would help in this case as you would still be able to use link preview on other smaller channels instead of the all or nothing you can currently do in the configs.

@brunnre8
Copy link
Member

brunnre8 commented Dec 5, 2023

If you have a server that can't handle a few irc users, you're gonna have a bad time on the internet.

Considering that the default of TL is to not show previews, people explicitly turned it on, probably because they want to have it.

Meaning your server will still get ddosed, by your measure, as those will keep it enabled.

If you really care, you can filter us on the server, we identify as twitterbot so it's easy enough

@TheTechRobo
Copy link

It's still a problem when someone sends a link to a server that happens to have this issue, and suddenly nobody can access it anymore.

@brunnre8
Copy link
Member

brunnre8 commented Dec 5, 2023

yes, sure
But that is a problem of your server, cache the stuff.
As said, TL users explicitly opted into the link previews, meaning they do want to look at them.

@ThatLurker
Copy link
Author

Yeah, I totally agree that that should be the case and this is not because of my servers sadly.
But still, adding a toggle for it per channel would make it even easier for people to toggle the feature on or off on channels that don't benefit from it. But still, leave it enabled on, for example, more media/meme heavy channels, as those types of stuff can easily take the traffic. But again, of course, this would require the user to turn it off themselves, but at least now they can still use it on other channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

No branches or pull requests

3 participants