Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web manifest to include screenshots and new icons #4800

Open
xPaw opened this issue Nov 6, 2023 · 2 comments
Open

Update web manifest to include screenshots and new icons #4800

xPaw opened this issue Nov 6, 2023 · 2 comments
Labels
help wanted Tickets the community can help us with, by either answering questions or sending us PRs. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.

Comments

@xPaw
Copy link
Member

xPaw commented Nov 6, 2023

  • The Lounge version: v4.4.0

Chrome devtools display the following warnings:

  • Richer PWA Install Ul won't be available on desktop. Please add at least one screenshot with the "form_factor" set to "wide".
  • Richer PWA Install Ul won't be available on mobile. Please add at least one screenshot for which "form_factor" is not set or set to a value other than "wide".
  • Declaring an icon with 'purpose: "any maskable" is discouraged. It is likely to look incorrect on some platforms due to too much or too little padding.
  • Actual size (150×150)px of lcon img/logo-grey-bg.svg does not match specified size (513×513px)
@xPaw xPaw added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. help wanted Tickets the community can help us with, by either answering questions or sending us PRs. labels Nov 6, 2023
@ASFAR2023
Copy link

cheek this
https://web.dev/articles/add-manifest?hl=ar#:~:text=forecast%20information%22%2C-,%22screenshots%22%3A%20%5B,-%7B%0A%C2%A0%20%C2%A0%20%C2%A0%20%22src

"screenshots": [
   {
     "src": "/images/screenshot1.png",
     "type": "image/png",
     "sizes": "540x720",
     "form_factor": "narrow"
   },
   {
     "src": "/images/screenshot2.jpg",
     "type": "image/jpg",
     "sizes": "720x540",
     "form_factor": "wide"
   }
 ]

jstjnsn added a commit to jstjnsn/thelounge that referenced this issue Dec 9, 2023
@jstjnsn
Copy link

jstjnsn commented Dec 9, 2023

Made a PR, please let me know if you approve of these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Tickets the community can help us with, by either answering questions or sending us PRs. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

No branches or pull requests

3 participants